build: set DESTCPU correctly for 'make binary' on Apple Silicon#40147
Closed
cheister wants to merge 1 commit intonodejs:masterfrom
Closed
build: set DESTCPU correctly for 'make binary' on Apple Silicon#40147cheister wants to merge 1 commit intonodejs:masterfrom
cheister wants to merge 1 commit intonodejs:masterfrom
Conversation
8dd0e91 to
03306d9
Compare
targos
approved these changes
Sep 19, 2021
targos
reviewed
Sep 19, 2021
jasnell
approved these changes
Sep 20, 2021
lpinca
approved these changes
Sep 23, 2021
Collaborator
21 tasks
Collaborator
This was referenced Sep 28, 2021
Collaborator
Collaborator
richardlau
approved these changes
Sep 29, 2021
Contributor
|
Landed in 88b497a...5607de8 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
PR-URL: #40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Sep 30, 2021
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Oct 5, 2021
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Feb 5, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Feb 5, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Backport-PR-URL: nodejs#41855
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Apr 15, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Backport-PR-URL: nodejs#41855
juanarbol
pushed a commit
that referenced
this pull request
May 1, 2022
PR-URL: #40147 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Backport-PR-URL: #41855
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
make binary -j8on an Apple Silicon M1 it looks like the DESTCPU is not set correctly in the Makefile so you get the following error when building opensslOn the M1 I get
arm64foruname -m. This PR sets the DESTCPU to arm64 and everything builds fine after that.