Closed
Conversation
Contributor
|
I mean, comparing new Date >= new Date; // true
new Date <= new Date; // true
new Date < new Date; // false
new Date > new Date; // false
new Date('1970-01-01') < new Date('2038-01-19'); // true
new Date('1970-01-01') > new Date('2038-01-19'); // false
// Equality on the other hand doesn't work
new Date == new Date // false
new Date('1970-01-01') == new Date('1970-01-01') // false |
Contributor
Author
|
Well, here the idea is to know whether a file has been modified by comparing modified times. which doesn't work. Actually that's the root cause of a bug I just fixed. |
Member
|
Keep in mind that "compare X and Y" does not mean "apply a JS comparison operator between X and Y"; for example, In any case, this can be sidestepped by just referring to |
jasnell
approved these changes
Sep 20, 2021
aduh95
reviewed
Sep 20, 2021
The current wording suggests to compare Date objects, which won't work.
64ba157 to
b65821f
Compare
targos
approved these changes
Sep 26, 2021
Contributor
|
Landed in a2ed30b...2b02d2f |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2021
The current wording suggests to compare Date objects, which won't work. PR-URL: #40134 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
The current wording suggests to compare Date objects, which won't work. PR-URL: #40134 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current wording suggests to compare Date objects, which won't work.