Conversation
nodejs-github-bot
added
doc
doc/api/http.md
Outdated
| * `msesc` {number} | ||
| * `callback` {Function} Optional function to be called when a timeout | ||
| occurs, Same as binding to the `timeout` event. | ||
| occurs. Same as binding to the `timeout` event. |
There was a problem hiding this comment.
| occurs. Same as binding to the `timeout` event. | |
| occurs. Same as binding to the `timeout` event. |
There was a problem hiding this comment.
Thanks. I'll look into adding https://github.com/freeletics/remark-lint-blank-lines something to lint for these kinds of things. I also wonder if I need to review #40042 a little closer.
There was a problem hiding this comment.
Actually, seems like I was right the first time. Making the suggested change but not concerned about #40042 as much.
There was a problem hiding this comment.
It looks like using remark to format the markdown (similar to using prettier for JS code) would have corrected this. I wonder if we should do that for all the files, and then have either a Makefile task or a GitHub Action to keep things that way.
There was a problem hiding this comment.
(FWIW prettier also works for markdown documents, it's not limited to JS code.)
Aren't we using remark already? That's what the name of the repo suggests: nodejs/remark-preset-lint-node.
There was a problem hiding this comment.
We use remark to lint but not to format. I'm in the midst of changing that.
Trott
added
the
author ready
targos
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 088c01b...0bafe6d |
PR-URL: #40133 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #40133 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #40133 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
9 participants
No description provided.