Skip to content

test: mark test-crypto-timing-safe-equal-benchmarks flaky#40065

Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau:cryptotiming
Closed

test: mark test-crypto-timing-safe-equal-benchmarks flaky#40065
richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau:cryptotiming

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Sep 10, 2021

This has been flaky for a long time.

Refs: #38226

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2021
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 10, 2021
@richardlau richardlau mentioned this pull request Sep 10, 2021
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 10, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39898/

@richardlau
Copy link
Member Author

richardlau commented Sep 10, 2021

Appears to have worked (test marked as flaky): https://ci.nodejs.org/job/node-test-commit-linuxone/28795/nodes=rhel7-s390x/testReport/(root)/test/pummel_test_crypto_timing_safe_equal_benchmarks_/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 10, 2021
mhdawson
mhdawson approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2021 •
edited by aduh95
Loading

Landed in b6ac7e6

@github-actions github-actions bot closed this Sep 12, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
@richardlau @nodejs-github-bot
test: mark test-crypto-timing-safe-equal-benchmarks flaky
2e4fc8e 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
aduh95 pushed a commit that referenced this pull request Sep 12, 2021
@richardlau @aduh95
test: mark test-crypto-timing-safe-equal-benchmarks flaky
b6ac7e6 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@richardlau richardlau deleted the cryptotiming branch September 12, 2021 19:34
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@richardlau @BethGriggs
test: mark test-crypto-timing-safe-equal-benchmarks flaky
04efafd 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@richardlau @BethGriggs
test: mark test-crypto-timing-safe-equal-benchmarks flaky
4367a61 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@AshCripps AshCripps AshCripps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau @nodejs-github-bot @jasnell @lpinca @tniessen @mhdawson @AshCripps