[v14.x backport] fs: improve fsPromises writeFile performance#39993
Closed
MoritzLoewenstein wants to merge 1 commit intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] fs: improve fsPromises writeFile performance#39993MoritzLoewenstein wants to merge 1 commit intonodejs:v14.x-stagingfrom
MoritzLoewenstein wants to merge 1 commit intonodejs:v14.x-stagingfrom
Conversation
nodejs-github-bot
added
fs
targos
approved these changes
Sep 5, 2021
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
nits to make the code closer to what's on the master branch
MoritzLoewenstein
force-pushed
the
fs-writefile-performance-backport
branch
from
d51c40c to
91cad74
Compare
targos
approved these changes
Sep 5, 2021
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
CI with Python 2 is broken: #39990 (comment) |
Linkgoron
reviewed
Sep 5, 2021
MoritzLoewenstein
force-pushed
the
fs-writefile-performance-backport
branch
from
91cad74 to
03d36bb
Compare
Linkgoron
approved these changes
Sep 6, 2021
Increase the write chunk size in fsPromises writeFile to improve performance. PR-URL: nodejs#37610 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
force-pushed
the
fs-writefile-performance-backport
branch
from
03d36bb to
9a5e60b
Compare
Member
|
I just rebased the branch. CI should pass now. |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
targos
pushed a commit
that referenced
this pull request
Sep 7, 2021
Increase the write chunk size in fsPromises writeFile to improve performance. PR-URL: #37610 Backport-PR-URL: #39993 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Member
|
Landed in d2834fb |
This was referenced Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #37610
'sister' pr of #39838