deps: V8: cherry-pick 22bee2c92123#39943
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Original commit message:
[serializer] print reference stack when external reference is unknown
Print the reference stack when V8 is unable to encode an external
reference in debug builds so that it's easier for the embedder
to track the external reference down.
Refs: nodejs#38905
Change-Id: Ia86eeb87833d7de0eccc7bc040301c78ddb3240c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988831
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/master@{#75546}
Refs: v8/v8@22bee2c
nodejs-github-bot
added
build
targos
approved these changes
Aug 30, 2021
jasnell
approved these changes
Aug 30, 2021
cjihrig
approved these changes
Aug 30, 2021
targos
added
the
author ready
Member
|
I'm going to land #39469 in a few hours and I think it includes this change. |
Member
Author
|
@targos Ah, nice, was just working on the user-land snapshot patch and wondering when this would land because it is helpful in debugging. Thanks for the reminder, I'll close it then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@22bee2c