meta: add mailmap entry for Ethan-Arrowood#39930
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
The next update-authors.js run will add a second entry to AUTHORS for Ethan-Arrowood because they use a new email address in a commit they authored very recently. Add the new email address to mailmap and update AUTHORS.
Trott
added
fast-track
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
added
the
meta
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Member
Author
|
(Adding fast-track label so we can land this before the authors.yml change so the first pull request we generate with the workflow can hopefully land without adjustments.) |
Member
Author
|
/ping @Ethan-Arrowood to make sure we are correct with the assumption that the newer address is the preferred address |
Ethan-Arrowood
approved these changes
Aug 29, 2021
Contributor
|
Thanks for the ping! Yes new email is correct ! |
antsmartian
approved these changes
Aug 29, 2021
lpinca
approved these changes
Aug 29, 2021
jasnell
approved these changes
Aug 30, 2021
Lxxyx
approved these changes
Aug 31, 2021
Lxxyx
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 9eff819...4e11817 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
The next update-authors.js run will add a second entry to AUTHORS for Ethan-Arrowood because they use a new email address in a commit they authored very recently. Add the new email address to mailmap and update AUTHORS. PR-URL: #39930 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
The next update-authors.js run will add a second entry to AUTHORS for Ethan-Arrowood because they use a new email address in a commit they authored very recently. Add the new email address to mailmap and update AUTHORS. PR-URL: #39930 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
The next update-authors.js run will add a second entry to AUTHORS for Ethan-Arrowood because they use a new email address in a commit they authored very recently. Add the new email address to mailmap and update AUTHORS. PR-URL: #39930 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next update-authors.js run will add a second entry to AUTHORS for
Ethan-Arrowood because they use a new email address in a commit they
authored very recently. Add the new email address to mailmap and update
AUTHORS.