test: use assert.match instead of regexp.test#39928
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
test: use assert.match instead of regexp.test#39928targos wants to merge 1 commit intonodejs:masterfrom
assert.match instead of regexp.test#39928targos wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
addons
targos
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
tniessen
approved these changes
Aug 29, 2021
targos
added
the
author ready
BridgeAR
approved these changes
Aug 29, 2021
RaisinTen
approved these changes
Aug 30, 2021
jasnell
approved these changes
Aug 30, 2021
Lxxyx
approved these changes
Aug 31, 2021
targos
added a commit
that referenced
this pull request
Aug 31, 2021
PR-URL: #39928 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Member
Author
|
Landed in 508890d |
targos
added a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39928 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos
added a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39928 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.