Closed
Conversation
aduh95
approved these changes
Aug 25, 2021
targos
approved these changes
Aug 25, 2021
gireeshpunathil
approved these changes
Aug 26, 2021
Trott
approved these changes
Aug 26, 2021
Member
|
Although the changes are looking good, I suggest removing the |
Contributor
Author
|
Okay, thanks for the suggestion! |
Mesteery
changed the title
lpinca
approved these changes
Aug 26, 2021
jasnell
approved these changes
Aug 26, 2021
gireeshpunathil
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/39887 ✔ Done loading data for nodejs/node/pull/39887 ----------------------------------- PR info ------------------------------------ Title doc: add Mesteery to triagers (#39887) Author Mestery (@Mesteery) Branch Mesteery:patch-2 -> nodejs:master Labels doc Commits 1 - doc: add Mesteery to triagers Committers 1 - Mestery PR-URL: https://github.com/nodejs/node/pull/39887 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Gireesh Punathil Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39887 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Gireesh Punathil Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 25 Aug 2021 19:53:20 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/39887#pullrequestreview-738862440 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39887#pullrequestreview-738866588 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/39887#pullrequestreview-738990556 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/39887#pullrequestreview-739037745 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39887#pullrequestreview-739407590 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39887#pullrequestreview-739507240 ✖ This PR needs to wait 10 more hours to land ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1173693538 |
github-actions
bot
added
the
commit-queue-failed
RaisinTen
approved these changes
Aug 27, 2021
Lxxyx
approved these changes
Aug 27, 2021
targos
added
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in b5ee5b5...e5670f4 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 27, 2021
PR-URL: #39887 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Member
|
sent invitation to @Mesteery to join @nodejs/issue-triage team |
Contributor
Author
|
Invitation accepted, thank you! |
Contributor
|
Welcome @Mesteery to the team. |
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39887 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39887 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to join the Triagers team, to be more useful, help manage issues and get more involved in Node.js.
I hereby declare that I have read and understood the Code of Conduct and will adhere to that.