meta: update .mailmap to remove duplicate AUTHORS entry for addaleax#39880
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
meta: update .mailmap to remove duplicate AUTHORS entry for addaleax#39880Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
meta
targos
approved these changes
Aug 25, 2021
richardlau
approved these changes
Aug 25, 2021
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
"update" is misspelled in the commit/PR title.
addaleax
approved these changes
Aug 25, 2021
Trott
changed the title
Member
Author
Fixed in both places. Thanks. I mistype that all the time. Guess I need to implement my "acceptable imperative verbs" rule in core-validate-commit. |
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
lpinca
approved these changes
Aug 25, 2021
jasnell
approved these changes
Aug 25, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in c04d621...95834d1 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
PR-URL: #39880 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39880 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.