lib: avoid creating a throw away object in validateObject#39807
Closed
aduh95 wants to merge 1 commit intonodejs:masterfrom
Closed
lib: avoid creating a throw away object in validateObject#39807aduh95 wants to merge 1 commit intonodejs:masterfrom
validateObject#39807aduh95 wants to merge 1 commit intonodejs:masterfrom
Conversation
lpinca
approved these changes
Aug 20, 2021
Member
Why undefined behavior? |
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
targos
approved these changes
Sep 18, 2021
targos
pushed a commit
that referenced
this pull request
Sep 18, 2021
PR-URL: #39807 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
|
Landed in e62d464 |
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #39807 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #39807 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also avoids unexpected behavior if
Object.prototype.allowArrayet al. is notundefined.