worker: remove file extension check#39788
Closed
Ayase-252 wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
errors
addaleax
approved these changes
Aug 17, 2021
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
It might also be good to add a test that a file with another extension can be loaded.
Member
Author
|
@addaleax Thanks, reviews are addressed, PTAL |
bmeck
reviewed
Aug 17, 2021
bmeck
suggested changes
Aug 17, 2021
Member
bmeck
left a comment
bmeck
left a comment
There was a problem hiding this comment.
It would be good to talk about the implications of this PR since it is trying to promote usage of a deprecated API.
Member
|
I think likely this is fine since we don't have |
jasnell
approved these changes
Aug 17, 2021
BridgeAR
approved these changes
Aug 22, 2021
bmeck
approved these changes
Aug 24, 2021
Member
bmeck
left a comment
bmeck
left a comment
There was a problem hiding this comment.
Couldn't think of any forwards compat concerns if we do introduce type:module
Member
|
@Ayase-252 can you please rebase (I think it will fix the linter issue) |
Ayase-252
force-pushed
the
feature/worker/remove-extension-check
branch
from
dfc24f8 to
1c6cd1c
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jasnell
pushed a commit
that referenced
this pull request
Aug 26, 2021
Fixes: #39124 PR-URL: #39788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
|
Landed in 229b7d2...52ebe0f |
jasnell
pushed a commit
that referenced
this pull request
Aug 26, 2021
PR-URL: #39788 Fixes: #39124 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Aug 26, 2021
PR-URL: #39788 Fixes: #39124 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Fixes: #39124 PR-URL: #39788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39788 Fixes: #39124 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39788 Fixes: #39124 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Fixes: #39124 PR-URL: #39788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39788 Fixes: #39124 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39788 Fixes: #39124 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of adding an option, remove the check entirely.
Fixes: #39124
Alternative to #39785