Open
Conversation
This commit fixes `uv_timer_start` usage on `ChannelWrap::StartTimer`, implements more precise timeout checking and missing tests for the `tries` option.
nodejs-github-bot
added
c++
Member
|
@nodejs/dns |
Contributor
Author
|
Any idea why the nvm, just saw #39725 |
addaleax
reviewed
Aug 11, 2021
Member
|
@nodejs/dns |
Contributor
|
Ping @nodejs/dns for reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing tests for new option
trieson Resolver I noticed that it took at least 900ms more than it should when the timeout was > 1000.So a 1000ms timeout would actually take ~1900ms to trigger.
The reason is that the wrapper would register a timer in which callback
intervalandtimeoutwas 1000ms in this case, which caused the callback to fire only after thistimeout, leading to one moreintervalof waiting to be fired again.In addition, this also adds missing tests for the option
tries!Refs: #39610 #39562