[v14.x backport] lint rules for globals#39448
Closed
aduh95 wants to merge 3 commits intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] lint rules for globals#39448aduh95 wants to merge 3 commits intonodejs:v14.x-stagingfrom
aduh95 wants to merge 3 commits intonodejs:v14.x-stagingfrom
Conversation
PR-URL: nodejs#38211 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#38230 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#38419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
approved these changes
Jul 19, 2021
Collaborator
github-actions
bot
added
lib / src
Collaborator
Collaborator
richardlau
approved these changes
Jul 19, 2021
richardlau
added
the
fast-track
Contributor
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
Member
|
Landed in 5f7c331...0d2b4b7. |
This was referenced Jul 20, 2021
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38211 Backport-PR-URL: nodejs#39448 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38230 Backport-PR-URL: nodejs#39448 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38419 Backport-PR-URL: nodejs#39448 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should unblock #39446, and should help notice uncompatible backports (
lib/child_process.jswas usingAbortControlleras a global, but it's not available as a global on v14.x...).Backports:
globalThisto primordials #38211primordials.globalThisinstead ofglobal#38230