stream: compose with async functions#39435
Closed
ronag wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
Enables async function support for stream.compose.
Member
Author
|
We disabled async function in the compose PR due to @benjamingr request to review the async fn API before landing. |
Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>
Member
Author
|
@nodejs/streams |
Member
|
Changes look good but does this need additional tests? |
Member
Author
The tests are already merged through the original PR. |
benjamingr
approved these changes
Jul 20, 2021
Collaborator
ronag
added
author ready
jasnell
approved these changes
Jul 20, 2021
Collaborator
Collaborator
Member
Author
|
Landed in 48ff0a1 |
ronag
added a commit
that referenced
this pull request
Jul 21, 2021
Enables async function support for stream.compose. PR-URL: #39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Depends on #39029 |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Jul 28, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Jul 29, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Jul 29, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 1, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 1, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 1, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2021
Enables async function support for stream.compose. PR-URL: nodejs#39435 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables async function support for stream.compose.