[v14.x backport] deps: update to [email protected]#39421
Closed
guybedford wants to merge 1 commit intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] deps: update to [email protected]#39421guybedford wants to merge 1 commit intonodejs:v14.x-stagingfrom
guybedford wants to merge 1 commit intonodejs:v14.x-stagingfrom
Conversation
Collaborator
richardlau
force-pushed
the
v14.x-staging
branch
from
8ea39c6 to
4ac719f
Compare
PR-URL: nodejs#39402 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
guybedford
force-pushed
the
cjs-module-lexer-update-14
branch
from
c4e7a0d to
88046f2
Compare
Collaborator
hybrist
approved these changes
Jul 20, 2021
Collaborator
Collaborator
Contributor
Author
|
Not sure what's going on with this CI run here, but this should still be good to merge I believe. Are there known issues with the 14 builds? |
Collaborator
Collaborator
Contributor
Author
|
Landed in ac76cdb. |
Contributor
|
@guybedford this landed a bit pre-maturely. The original change hasn't yet gone out in a 16.x release and we need it to be out on Current for at least 2 weeks before backporting. Generally I've avoided landing changes that are not yet ready for backport to avoid it accidentally going out pre-maturely in an LTS release |
Contributor
Author
|
Thanks @MylesBorins I've reverted and reopened this in #39531. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #39402 for Node.js 14.x.
@nodejs/modules