streams: implement CompressionStream and DecompressionStream#39348
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
streams: implement CompressionStream and DecompressionStream#39348jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
lib / src
aduh95
reviewed
Jul 11, 2021
jasnell
force-pushed
the
compression-streams
branch
from
12ff355 to
c7623f1
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
should this be a separate warning due to wicg draft status? |
Member
Author
|
I don't think a separate warning is necessary or really all that helpful. At the most, it won't move out of experimental at the same time as the rest of the webstreams stuff. |
aduh95
approved these changes
Jul 13, 2021
jasnell
force-pushed
the
compression-streams
branch
from
8422f05 to
1e09cb6
Compare
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
mcollina
requested changes
Jul 14, 2021
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I think those should exposed via zlib and not via streams/web
mcollina
requested changes
Jul 14, 2021
Member
Author
I'd prefer to keep all of the stream/web related things together. The intent is for these to eventually be lazy-loaded globals anyway. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: James M Snell <[email protected]>
jasnell
force-pushed
the
compression-streams
branch
from
3797a84 to
4c7a68b
Compare
Collaborator
Member
Author
|
Landed in 09ad64d |
jasnell
added a commit
that referenced
this pull request
Jul 14, 2021
Signed-off-by: James M Snell <[email protected]> PR-URL: #39348 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
|
Please don't forget to ping @nodejs/streams |
Member
|
Depends on #39134 |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Aug 26, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in nodejs@f57a0e4d8b and released in version 16.7.0. Reset the added: version to REPLACEME. Refs: nodejs#39348 Refs: nodejs#39899
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Aug 26, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in nodejs@f57a0e4d8b and released in version 16.7.0. Reset the `added:` version to `REPLACEME`. Refs: nodejs#39348 Refs: nodejs#39899
jasnell
pushed a commit
that referenced
this pull request
Aug 28, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in f57a0e4d8b and released in version 16.7.0. Reset the `added:` version to `REPLACEME`. Refs: #39348 Refs: #39899 PR-URL: #39901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the web streams adapters PR #39134 (first commit here is from that PR)
Implements the Compression Streams Web API using the adapters