Fix typo in --specifier-resolution=[node]

[Urigo]

No description provided.

[mscdex]

I don't believe this change is correct. "mode" here is referring to the parameter name, whereas "node" is one possible value for the "mode" parameter. The "mode" could also have a value of "explicit".

[benjamingr]

Thanks for this PR like mscdex said this is not a typo :)

Changes to the docs making that clearer are welcome though I'm personally not sure how to make it clearer.

[Urigo]

ohh got it, sorry about that :)

mmm I guess maybe something different then mode? maybe resolution-mode ?

[gireeshpunathil]

mmm I guess maybe something different then mode? maybe resolution-mode ?

from the very fact that this PR exists shows that the word mode is confusing, and makes sense to change it, though resolution-mode looks a bit longer for the purpose?

/cc @nodejs/loaders

[benjamingr]

I think resolution-mode is perfectly fine (especially since it's only for the docs example and not the actual flag) :)

PR update welcome

[Urigo]

Thanks for the comments!
Updated

[tniessen]

This line now exceeds 80 characters, while the rest of the paragraph is wrapped at 80 chars. Not sure whether we usually fix this.

[JakobJingleheimer]

Yes, it fails the lint doc check, which blocks merging.

[benjamingr]

@tniessen in my anecdotal experience we usually fix this for first time contributors if they are unable to do so themselves.

[benjamingr]

Fix looks good - please drop it to two lines in order to meet the 80 character limit :)

[aduh95]

The flag was removed in #44859.

[benjamingr]

Sorry for dropping the ball on getting this through the finish line back then @Urigo ! Thank you for your contribution