Closed
Conversation
Update ESLint to 7.30.0
Trott
approved these changes
Jul 3, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Rubber stamp LGTM. Wonder if we should move things like this to PRs opened by a bot or GitHub Actions. The current system is working fine, but that's mostly because there's personal trust here.
Lxxyx
approved these changes
Jul 3, 2021
lpinca
approved these changes
Jul 4, 2021
cjihrig
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 70cf0dc...6dfdb0a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 5, 2021
Update ESLint to 7.30.0 PR-URL: #39242 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
Update ESLint to 7.30.0 PR-URL: #39242 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Update ESLint to 7.30.0 PR-URL: #39242 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.30.0