doc: add docs for duplex.allowHalfOpen property#39126
Closed
pimterry wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add docs for duplex.allowHalfOpen property#39126pimterry wants to merge 1 commit intonodejs:masterfrom
pimterry wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
doc
lpinca
approved these changes
Jun 24, 2021
Member
|
I think there is no test that verifies that changing this on the fly is safe (especially for special streams that inherits from |
Member
Author
|
This is approved and it's a quick simple docs change that was agreed in #38989. Is it possible to get this merged? |
jasnell
approved these changes
Aug 30, 2021
jasnell
added
the
author ready
Member
|
Landed in d14878d. |
lpinca
pushed a commit
that referenced
this pull request
Aug 30, 2021
PR-URL: #39126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Amazing, thanks! 👍👍👍 |
1 task
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38989