deps: update V8 to 9.2 by targos · Pull Request #38990 · nodejs/node

targos · 2021-06-10T11:32:29Z

No description provided.

nodejs-github-bot · 2021-06-10T11:33:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38556/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4038/

targos · 2021-06-10T11:36:16Z

13:34:56 + gn gen -v out.gn/s390x.release '--args=is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true'
13:34:56 ERROR at //.gn:18:20: Assignment had no effect.
13:34:56 no_check_targets = [
13:34:56                    ^
13:34:56 You set the variable "no_check_targets" here and it was unused before it went
13:34:56 out of scope.

Looks like we need to adapt the V8 build/test script

targos · 2021-06-10T12:35:36Z

I cherry-picked a commit to fix the ARM build.

The error on Windows is the following and still happens on V8 master:

D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(462,31): error C3779: 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers': a function that returns 'auto' cannot be used before it is defined [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(422): message : see declaration of 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(461): message : while compiling class template member function 'v8::internal::Register v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::GetRegisterParameter(int)' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(1771): message : see reference to class template instantiation 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>' being compiled [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(462,31): error C3779: 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers': a function that returns 'auto' cannot be used before it is defined [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(422): message : see declaration of 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(461): message : while compiling class template member function 'v8::internal::Register v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::GetRegisterParameter(int)' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(1771): message : see reference to class template instantiation 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>' being compiled [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]

nodejs-github-bot · 2021-06-10T12:36:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38557/

targos · 2021-06-10T14:13:38Z

Error on some of the Linux hosts:

14:46:45   touch /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-last-latest-x64/out/Release/obj.target/tools/v8_gypfiles/v8_compiler_for_mksnapshot.stamp
14:46:45 make[2]: execvp: printf: Argument list too long
14:46:56 make[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:1007: /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-last-latest-x64/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a] Error 127

richardlau · 2021-06-10T15:17:42Z

13:34:56 + gn gen -v out.gn/s390x.release '--args=is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true'
13:34:56 ERROR at //.gn:18:20: Assignment had no effect.
13:34:56 no_check_targets = [
13:34:56                    ^
13:34:56 You set the variable "no_check_targets" here and it was unused before it went
13:34:56 out of scope.

Looks like we need to adapt the V8 build/test script

@miladfarca @john-yan Is this something we've seen upstream in V8 for PPC/s390x? Do we need a gn update?

miladfarca · 2021-06-10T15:47:47Z

@richardlau I have tried both these gn versions on V8 branch-heads/9.2, using the same arguments and it runs successfully:

1824 (5da62d5e)
and
1912 (d3fe8f4d)

Definitely try updating gn first if its older than above versions.

richardlau · 2021-06-10T16:24:51Z

FTR we're currently on

1618 (f0a6900)

for PPC and

1620 (570aaed)

for s390x. I'll try to get them updated.

targos · 2021-06-15T19:00:17Z

I opened a CL to fix the Windows build: https://chromium-review.googlesource.com/c/v8/v8/+/2964095

nodejs-github-bot · 2021-06-16T11:19:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38650/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4060/

targos · 2021-06-16T12:55:35Z

Other error on Windows (debug):

13:32:35 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\common-operator.h(615,3): error C3615: constexpr function 'v8::internal::compiler::FrameState::FrameState' cannot result in a constant expression [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
13:32:35 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\common-operator.h(620,1): message : failure was caused by call of undefined function or one not declared 'constexpr' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
13:32:35 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\common-operator.h(620,1): message : see usage of 'v8::internal::compiler::Node::opcode' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

richardlau · 2021-06-16T19:53:18Z

I've updated the version of gn we're using on Linux ppc64/s390x (nodejs/build#2675 for the Ansible scripts that automate this).

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4065/
(ppc64 and s390x no longer fail due to ERROR at //.gn:18:20: Assignment had no effect. error)

richardlau · 2021-06-16T19:57:05Z

s390x built but fails a test:

20:52:11 === mjsunit/tools/tickprocessor ===
20:52:11 --- stderr ---
20:52:11 file="/data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/tools/tickprocessor-test-large.log": Error loading file
20:52:11 --- stdout ---
20:52:11 === testProcessing-Default ===
20:52:11 === testProcessing-SeparateBytecodes ===
20:52:11 === testProcessing-SeparateBaselineHandlers ===
20:52:11 === testProcessing-SeparateIc ===
20:52:11 === testProcessing-IgnoreUnknown ===
20:52:11 === testProcessing-GcState ===
20:52:11 === testProcessing-OnlySummary ===
20:52:11 === testProcessing-FunctionInfo ===
20:52:11 === testProcessing-DefaultLarge ===
20:52:11 /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/tickprocessor.mjs:67: Error: Error loading file
20:52:11     return read(fileName);
20:52:11            ^
20:52:11 Command: /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test -e TEST_FILE_NAME="/data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/tools/tickprocessor.mjs" /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/tools/tickprocessor.mjs --random-seed=-137790089 --nohard-abort --testing-d8-test-runner

richardlau · 2021-06-16T20:47:26Z

ppc64 also failed the tickprocessor test but also has three crashes
cc @nodejs/platform-ppc

16:33:41 === cctest/test-gc/RunWasmTurbofan_RefTrivialCasts ===
16:33:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/ppc64.release/cctest test-gc/RunWasmTurbofan_RefTrivialCasts --random-seed=-451154066 --nohard-abort --testing-d8-test-runner
16:33:41 exit code: -4 [FFFFFFFC]
16:33:41 --- CRASHED ---
16:33:41 === cctest/test-run-wasm/RunWasmLiftoff_Select_s128_parameters ===
16:33:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/ppc64.release/cctest test-run-wasm/RunWasmLiftoff_Select_s128_parameters --random-seed=-451154066 --nohard-abort --testing-d8-test-runner
16:33:41 exit code: -4 [FFFFFFFC]
16:33:41 --- CRASHED ---
16:33:41 === cctest/test-run-wasm/RunWasmTurbofan_Select_s128_parameters ===
16:33:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/ppc64.release/cctest test-run-wasm/RunWasmTurbofan_Select_s128_parameters --random-seed=-451154066 --nohard-abort --testing-d8-test-runner
16:33:41 exit code: -4 [FFFFFFFC]
16:33:41 --- CRASHED ---

miladfarca · 2021-06-16T21:44:29Z

@richardlau PPC failures should be because of not having Simd support on P8, could you cherry pick this and try again: https://chromium-review.googlesource.com/c/v8/v8/+/2927210

test/mjsunit/tools/tickprocessor-test-large.log was added in this CL:
https://chromium-review.googlesource.com/c/v8/v8/+/2784686

Test was skipped on most platforms later on, file should still be present tho:
https://chromium-review.googlesource.com/c/v8/v8/+/2848461

richardlau · 2021-06-17T00:35:25Z

@richardlau PPC failures should be because of not having Simd support on P8, could you cherry pick this and try again: https://chromium-review.googlesource.com/c/v8/v8/+/2927210

Thanks, cherry-picked that one across.
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4067/

test/mjsunit/tools/tickprocessor-test-large.log was added in this CL:
https://chromium-review.googlesource.com/c/v8/v8/+/2784686

Test was skipped on most platforms later on, file should still be present tho:
https://chromium-review.googlesource.com/c/v8/v8/+/2848461

AFAICT V8 9.2.230.10 already contains v8/v8@e1e1220.

miladfarca · 2021-06-17T02:15:20Z

That's right, but I'm not sure why tickprocessor-test-large.log is missing in this PR, it does exist on V8 9.2.230.10: https://github.com/v8/v8/blob/cd9bcb6680df93d185eb274c23a2137ce4d44e14/test/mjsunit/tools/tickprocessor-test-large.log

richardlau · 2021-06-17T10:06:41Z

That's right, but I'm not sure why tickprocessor-test-large.log is missing in this PR, it does exist on V8 9.2.230.10: https://github.com/v8/v8/blob/cd9bcb6680df93d185eb274c23a2137ce4d44e14/test/mjsunit/tools/tickprocessor-test-large.log

It's ignored by git due to *.log in deps/v8/.gitignore:

node/deps/v8/.gitignore

Line 7 in a23ac88

*.log

same as in upstream for 9.2.230.10: https://github.com/v8/v8/blob/cd9bcb6680df93d185eb274c23a2137ce4d44e14/.gitignore#L7

I've pushed a fixup commit. Retesting: https://ci.nodejs.org/job/node-test-commit-v8-linux/4069/

targos · 2021-06-17T12:41:52Z

Failure on the benchmark machine is not obvious: https://ci.nodejs.org/job/node-test-commit-v8-linux/4069/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

nodejs-github-bot · 2021-06-19T18:07:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38696/

targos · 2021-06-20T08:20:58Z

20:12:29 make[2]: execvp: printf: Argument list too long

What can we do about this?

targos · 2021-06-20T08:35:49Z

Trying with /std:c++17 on Windows. https://ci.nodejs.org/job/node-test-commit-windows-fanned/43432/
I think the debug build error comes from v8/v8@499f169

Edit: the error remains.

PR-URL: nodejs/node#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 10, 2021

targos changed the title ~~deps: update V8 to 92~~ deps: update V8 to 9.2 Jun 10, 2021

github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 10, 2021

targos added the wip Issues and PRs that are still a work in progress. label Jun 10, 2021

targos mentioned this pull request Jun 15, 2021

Node.js Technical Steering Committee (TSC) Meeting 2021-06-17 nodejs/TSC#1040

Closed

richardlau mentioned this pull request Jun 16, 2021

ansible: build gn from source on Linux PPC/s390x nodejs/build#2675

Merged

Uh oh!

Conversation

targos commented Jun 10, 2021

Uh oh!

nodejs-github-bot commented Jun 10, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 10, 2021

Uh oh!

nodejs-github-bot commented Jun 10, 2021

Uh oh!

targos commented Jun 10, 2021

Uh oh!

richardlau commented Jun 10, 2021

Uh oh!

miladfarca commented Jun 10, 2021

Uh oh!

richardlau commented Jun 10, 2021

Uh oh!

targos commented Jun 15, 2021

Uh oh!

nodejs-github-bot commented Jun 16, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 16, 2021

Uh oh!

richardlau commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Jun 16, 2021

Uh oh!

richardlau commented Jun 16, 2021

Uh oh!

miladfarca commented Jun 16, 2021

Uh oh!

richardlau commented Jun 17, 2021

Uh oh!

miladfarca commented Jun 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Jun 17, 2021

Uh oh!

targos commented Jun 17, 2021

Uh oh!

nodejs-github-bot commented Jun 19, 2021

Uh oh!

targos commented Jun 20, 2021

Uh oh!

targos commented Jun 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

nodejs-github-bot commented Jun 10, 2021 •

edited by targos

Loading

targos commented Jun 10, 2021 •

edited

Loading

nodejs-github-bot commented Jun 16, 2021 •

edited by targos

Loading

richardlau commented Jun 16, 2021 •

edited

Loading

miladfarca commented Jun 17, 2021 •

edited

Loading

targos commented Jun 20, 2021 •

edited

Loading