docs: use await in filehandle.truncate() snippet#38939
Closed
RA80533 wants to merge 1 commit intonodejs:masterfrom
Closed
docs: use await in filehandle.truncate() snippet#38939RA80533 wants to merge 1 commit intonodejs:masterfrom
await in filehandle.truncate() snippet#38939RA80533 wants to merge 1 commit intonodejs:masterfrom
Conversation
The example snippet of filehandle.close() uses the `await` keyword based on convention. This change updates the example snippet of filehandle.truncate() to similarly use the keyword for the purposes of consistency.
github-actions
bot
added
doc
bl-ue
approved these changes
Jun 5, 2021
Member
|
/cc @jasnell who I think wrote this line. |
addaleax
approved these changes
Jun 5, 2021
VoltrexKeyva
approved these changes
Jun 5, 2021
RaisinTen
approved these changes
Jun 5, 2021
RaisinTen
added
the
author ready
lpinca
approved these changes
Jun 5, 2021
cjihrig
approved these changes
Jun 5, 2021
ycjcl868
approved these changes
Jun 6, 2021
Lxxyx
approved these changes
Jun 11, 2021
Lxxyx
added
commit-queue
Lxxyx
pushed a commit
that referenced
this pull request
Jun 11, 2021
The example snippet of filehandle.close() uses the `await` keyword based on convention. This change updates the example snippet of filehandle.truncate() to similarly use the keyword for the purposes of consistency. PR-URL: #38939 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Member
|
Landed in bf2473d |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
The example snippet of filehandle.close() uses the `await` keyword based on convention. This change updates the example snippet of filehandle.truncate() to similarly use the keyword for the purposes of consistency. PR-URL: #38939 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
The example snippet of filehandle.close() uses the `await` keyword based on convention. This change updates the example snippet of filehandle.truncate() to similarly use the keyword for the purposes of consistency. PR-URL: #38939 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Member
|
Backport to v14.x-staging blocked on #37170. |
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
The example snippet of filehandle.close() uses the `await` keyword based on convention. This change updates the example snippet of filehandle.truncate() to similarly use the keyword for the purposes of consistency. PR-URL: #38939 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example snippet of filehandle.close() uses the
awaitkeywordbased on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.