crypto: use compatible version of EVP_CIPHER_name#38925
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: use compatible version of EVP_CIPHER_name#38925codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
c++
codebytere
force-pushed
the
use-compatible-fn
branch
from
bb63c3d to
b811eca
Compare
bl-ue
approved these changes
Jun 4, 2021
Contributor
|
Great catch 😄 |
Trott
approved these changes
Jun 4, 2021
richardlau
approved these changes
Jun 4, 2021
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Do we need a comment in the code to stop someone changing it back?
codebytere
force-pushed
the
use-compatible-fn
branch
2 times, most recently
from
61057ac to
9c4a94b
Compare
addaleax
approved these changes
Jun 5, 2021
Collaborator
codebytere
force-pushed
the
use-compatible-fn
branch
from
9c4a94b to
11202fe
Compare
Collaborator
fhinkel
approved these changes
Jun 8, 2021
Collaborator
codebytere
added a commit
that referenced
this pull request
Jun 8, 2021
PR-URL: #38925 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Member
Author
|
Landed in 911ff34 |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38925 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Member
|
Doesn't land cleanly on v14.x-staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EVP_CIPHER_nameis only exposed via OpenSSL, but it's defined in the source code asOBJ_nid2sn(EVP_CIPHER_nid(e)), both of which are available in BoringSSL and OpenSSL. This PR switches to use that instead for better compatibility.