doc: deprecate type coercion for dns.lookup options#38906
doc: deprecate type coercion for dns.lookup options#38906aduh95 wants to merge 4 commits intonodejs:masterfrom
dns.lookup options#38906Conversation
34fa6fa to
82ffb69
Compare
82ffb69 to
713319c
Compare
verbatim optiondns.lookup options
|
@nodejs/tsc if #37931 lands, the type coercion on the Other For reference, here's the current logic: Lines 115 to 120 in fa1a842 |
| of the `PerformanceEntry` object. The existing accessors have been | ||
| deprecated and should no longer be used. | ||
|
|
||
| ### DEP0153: `dns.lookup` and `dnsPromises.lookup` options type coercion |
There was a problem hiding this comment.
I'm landing this now, but in general deprecation PRs should leave the code number unassigned (e.g. use DEP0XXX) so that the code can be assigned when it is landed.
|
Landed in fae352a...f41893e |
PR-URL: #38906 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814 PR-URL: #39875
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814 PR-URL: #39875
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) nodejs#38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) nodejs#39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) nodejs#39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) nodejs#39814 PR-URL: nodejs#39875
The plan is to replace this check:
node/lib/internal/dns/promises.js
Lines 115 to 117 in d8797f5
with a more robust
validateBooleancheck – and similar for otherdns.lookupoptions.