tools: refactor snapshot builder#38902
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
github-actions
bot
added
c++
Collaborator
bl-ue
suggested changes
Jun 2, 2021
Contributor
There was a problem hiding this comment.
Suggestion: indexes → indices (while both are correct, the latter is preferred for technical use).
Hopefully I've updated all references to isolate_data_indexes and NodeMainInstance::GetIsolateDataIndices 🤞🏻
Edit: I just realized that you didn't add this code, you moved it from a different file. Scrap these suggestions if they'll cause any more complications than meets the untrained eye viewing this PR ;)
Collaborator
bl-ue
approved these changes
Jun 2, 2021
Contributor
bl-ue
left a comment
bl-ue
left a comment
There was a problem hiding this comment.
One thing: for stringstreams that you only need write to, it's better to use ostringstream.
Member
|
These need to be updated to src/node.cc:1113: indexes = NodeMainInstance::GetIsolateDataIndexes();
src/node_main_instance.h:70: static const std::vector<size_t>* GetIsolateDataIndexes();
src/node_snapshot_stub.cc:13:const std::vector<size_t>* NodeMainInstance::GetIsolateDataIndexes() { |
Contributor
|
If you don't want to do all that in this PR, I'd be happy to open a new PR correct the naming, @joyeecheung. |
joyeecheung
force-pushed
the
snapshot-refactor
branch
from
7d8d5f9 to
73528a6
Compare
Collaborator
bl-ue
reviewed
Jun 2, 2021
Contributor
bl-ue
left a comment
bl-ue
left a comment
There was a problem hiding this comment.
Sorry for the spamming...this is the last one 😛
joyeecheung
force-pushed
the
snapshot-refactor
branch
from
73528a6 to
fa2bcbc
Compare
This patch: - Moves the snapshot building code to src/ so that we can reuse it later when generating custom snapshots from an entry point accepted by the node binary. - Create a SnapshotData struct that incorporates all the data useful for a snapshot blob, including both the V8 data and the Node.js data.
joyeecheung
force-pushed
the
snapshot-refactor
branch
from
fa2bcbc to
6cb0e58
Compare
Collaborator
bl-ue
reviewed
Jun 2, 2021
legendecas
approved these changes
Jun 3, 2021
legendecas
added
the
author ready
joyeecheung
added a commit
that referenced
this pull request
Jun 10, 2021
This patch: - Moves the snapshot building code to src/ so that we can reuse it later when generating custom snapshots from an entry point accepted by the node binary. - Create a SnapshotData struct that incorporates all the data useful for a snapshot blob, including both the V8 data and the Node.js data. PR-URL: #38902 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
Author
|
Landed in 30e8b5e |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
This patch: - Moves the snapshot building code to src/ so that we can reuse it later when generating custom snapshots from an entry point accepted by the node binary. - Create a SnapshotData struct that incorporates all the data useful for a snapshot blob, including both the V8 data and the Node.js data. PR-URL: #38902 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
This patch: - Moves the snapshot building code to src/ so that we can reuse it later when generating custom snapshots from an entry point accepted by the node binary. - Create a SnapshotData struct that incorporates all the data useful for a snapshot blob, including both the V8 data and the Node.js data. PR-URL: #38902 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
|
Doesn't land cleanly on v14.x-staging. Blocked on at least #37114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch:
later when generating custom snapshots from an entry point accepted
by the node binary.
for a snapshot blob, including both the V8 data and the Node.js
data.