crypto: use EVP_get_cipherbynid directly#38901
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: use EVP_get_cipherbynid directly#38901codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
c++
richardlau
approved these changes
Jun 2, 2021
jasnell
approved these changes
Jun 2, 2021
bl-ue
approved these changes
Jun 2, 2021
tniessen
approved these changes
Jun 2, 2021
Collaborator
addaleax
approved these changes
Jun 5, 2021
Member
Author
|
Landed in eb3a448 |
codebytere
added a commit
that referenced
this pull request
Jun 6, 2021
PR-URL: #38901 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38901 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Member
|
Doesn't land cleanly on v14.x-staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup - instead of calling
OBJ_nid2sn(nid)and passing that result toEVP_get_cipherbyname, we can pass theniddirectly toEVP_get_cipherbynid.Works with BoringSSL and OpenSSL both.