src: make InitializeOncePerProcess more flexible#38888
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
Closed
src: make InitializeOncePerProcess more flexible#38888codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere wants to merge 1 commit intonodejs:masterfrom
Conversation
codebytere
added
the
embedding
github-actions
bot
added
c++
joyeecheung
approved these changes
Jun 1, 2021
bl-ue
approved these changes
Jun 1, 2021
addaleax
requested changes
Jun 1, 2021
jasnell
approved these changes
Jun 1, 2021
codebytere
changed the title
codebytere
force-pushed
the
wrap-v8-platform
branch
from
cdaa7ed to
900f907
Compare
codebytere
added
the
semver-minor
codebytere
force-pushed
the
wrap-v8-platform
branch
from
900f907 to
dc7a376
Compare
Collaborator
addaleax
approved these changes
Jun 3, 2021
codebytere
force-pushed
the
wrap-v8-platform
branch
from
79b074c to
aa245e2
Compare
Collaborator
Member
Author
|
Landed in d8d1d96 |
codebytere
added a commit
that referenced
this pull request
Jun 7, 2021
PR-URL: #38888 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38888 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 24, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 24, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds customizability to
InitializeOncePerProcessby adding an overload with a third parameter containing flags which specify which aspects ofInitializeOncePerProcessto run.