doc: standardize on "Long Term Support" by Trott · Pull Request #38841 · nodejs/node

Trott · 2021-05-29T15:52:05Z

I'll add a lint rule to the Node.js remark lint preset.

phershbe · 2021-05-29T16:54:56Z

Yeah sounds good, thank you for making the changes. I added another comment to the discussion that we having before. I'm listing the link for anybody who wants to understand the logic behind the changes: #38839

Refs: nodejs/node#38841 Refs: nodejs/node#38839

mhdawson

LGTM

Use "Long Term Support" rather than "long term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Use "Long Term Support" rather than "Long-term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Trott · 2021-05-31T18:43:47Z

Landed in 16ae378...58bd046

bl-ue · 2021-05-31T18:50:56Z

Why does GH say that the PR was merged, rather than closed? It does that sometimes, but it's not clear to me why. 🤔

Trott · 2021-06-01T00:47:43Z

Why does GH say that the PR was merged, rather than closed? It does that sometimes, but it's not clear to me why. 🤔

If people follow the general procedure for this repo, it will end up Closed. However, there is an optional step that I always take where, before pushing the change to the master branch, you force-push it to the PR branch. Some users don't allow project collaborators to force push to their branches, but most do (as it's the default in GitHub--you have to uncheck a box when opening the pull request to prevent it). So if that works, it ends up being purple and merged, which people seem to appreciate and which I gather affects some tooling and GitHub stats in a positive way.

Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>