Closed
Conversation
github-actions
bot
added
the
tools
cjihrig
approved these changes
May 23, 2021
bl-ue
approved these changes
May 24, 2021
Trott
approved these changes
May 25, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Rubber-stamp LGTM assuming this was generated with the usual tools/updat-eslint.shscript. I certainly like the 44K lines removed.
Contributor
|
Yeah, tasty crunch. 😋 Looks like they removed their eslint/eslint#14098 & eslint/eslint#14287 are the causes of this. |
Contributor
|
woot, lodash is a scourge that should be wiped from the planet. |
lpinca
added a commit
that referenced
this pull request
May 26, 2021
PR-URL: #38764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in b6471c9. |
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #38764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
PR-URL: #38764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38764 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.27.0