test: set locale for datetime-change-notify test#38741
Closed
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Closed
test: set locale for datetime-change-notify test#38741Lxxyx wants to merge 1 commit intonodejs:masterfrom
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Conversation
The time zone output by toString() will change with user's language, use toLocaleString() to set the time zone.
github-actions
bot
added
needs-ci
jasnell
approved these changes
May 20, 2021
richardlau
approved these changes
May 20, 2021
Lxxyx
added
author ready
Collaborator
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Member
|
Landed in 80ed0a6 |
jasnell
pushed a commit
that referenced
this pull request
May 24, 2021
The time zone output by toString() will change with user's language, use toLocaleString() to set the time zone. PR-URL: #38741 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
The time zone output by toString() will change with user's language, use toLocaleString() to set the time zone. PR-URL: #38741 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
Member
|
Depends on #38642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time zone output by
toString()will change with user's language, usetoLocaleString()to set the time zone.This test will fail on a computer with the language set to Chinese.
Example:
use
toString()use
toLocaleString()