Skip to content

src: fix compiler warnings in node_buffer.cc#38722

Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen:src/fix-compiler-warnings-in-node_buffer.cc
Closed

src: fix compiler warnings in node_buffer.cc#38722
RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen:src/fix-compiler-warnings-in-node_buffer.cc

Conversation

@RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented May 18, 2021 •
edited
Loading

The variables could be initialized to 0 to avoid the warnings from
-Wmaybe-uninitialized.

Fixes: #38718

@targos
Copy link
Member

targos commented May 18, 2021

Any idea why the warnings are only emitted on v14.x branches?

@targos
Copy link
Member

targos commented May 19, 2021

/cc @addaleax ?

@github-actions github-actions bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 19, 2021
addaleax
addaleax approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos no idea; and I think that warnings would be okay to ignore here as well, as they seem like false positives to me.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2021
richardlau
richardlau reviewed May 19, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has cleared up most of the compiler warnings I get when building locally with GCC 10 (#38718 (comment)) but one still remains:

../src/node_buffer.cc: In function ‘void node::Buffer::{anonymous}::Fill(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_buffer.cc:646:35: error: ‘start’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  646 |   char* ptr = ts_obj_data + start + str_length;
      |               ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
cc1plus: all warnings being treated as errors

@RaisinTen
src: fix compiler warnings in node_buffer.cc
2ab4e90 
The variables could be initialized to `0` to avoid the warnings from
`-Wmaybe-uninitialized`.

Fixes: nodejs#38718
@RaisinTen RaisinTen force-pushed the src/fix-compiler-warnings-in-node_buffer.cc branch from 15303b2 to 2ab4e90 Compare May 19, 2021 15:24
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen
Copy link
Member Author

RaisinTen commented May 19, 2021

@richardlau Updated the PR to initialize start as well. PTAL.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 22, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38281/ 💚

@jasnell
Copy link
Member

jasnell commented May 24, 2021

Landed in 7766b38

jasnell pushed a commit that referenced this pull request May 24, 2021
@RaisinTen @jasnell
src: fix compiler warnings in node_buffer.cc
7766b38 
The variables could be initialized to `0` to avoid the warnings from
`-Wmaybe-uninitialized`.

Fixes: #38718

PR-URL: #38722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@jasnell jasnell closed this May 24, 2021
@RaisinTen RaisinTen deleted the src/fix-compiler-warnings-in-node_buffer.cc branch May 24, 2021 14:38
targos pushed a commit that referenced this pull request May 25, 2021
@RaisinTen @targos
src: fix compiler warnings in node_buffer.cc
267ddff 
The variables could be initialized to `0` to avoid the warnings from
`-Wmaybe-uninitialized`.

Fixes: #38718

PR-URL: #38722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request May 31, 2021
@RaisinTen @danielleadams
src: fix compiler warnings in node_buffer.cc
9ca5c0e 
The variables could be initialized to `0` to avoid the warnings from
`-Wmaybe-uninitialized`.

Fixes: #38718

PR-URL: #38722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
targos pushed a commit that referenced this pull request Jun 5, 2021
@RaisinTen @targos
src: fix compiler warnings in node_buffer.cc
4e99edb 
The variables could be initialized to `0` to avoid the warnings from
`-Wmaybe-uninitialized`.

Fixes: #38718

PR-URL: #38722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@RaisinTen @targos
src: fix compiler warnings in node_buffer.cc
8a60ae2 
The variables could be initialized to `0` to avoid the warnings from
`-Wmaybe-uninitialized`.

Fixes: #38718

PR-URL: #38722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@richardlau richardlau mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@JungMinu JungMinu JungMinu approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler warnings make test-linux workflow fail on v14.x

7 participants

@RaisinTen @targos @nodejs-github-bot @jasnell @addaleax @JungMinu @richardlau