doc: change color of doctag on night mode#38652
doc: change color of doctag on night mode#38652Ayase-252 wants to merge 1 commit intonodejs:masterfrom
Conversation
DerekNonGeneric
left a comment
DerekNonGeneric
left a comment
There was a problem hiding this comment.
Sweet!
Thanks, you can do .hljs-type if you want to too, but that would also need the light-mode styles too, so probably not in this PR.
/cc @nodejs/documentation as an FYI
|
I think it is a great idea. I will open other PR to adjust |
|
@Ayase-252, that sounds like a good idea! Pick a nice color for It should be distinguishable from the JSDoc tag (not the same color). Thanks in advance. :) |
|
/to @Ayase-252 check out what GitHub has done here. They are like whitish or something in the dark mode, so you may not want to diverge too far from that.
That is a gist in darkmode, so check it for yourself. |
|
OK, will check. Looks like Github uses same color of variable to |
|
@Ayase-252, they use a different syntax highlighter (and it is broken as you can see). It is probably best to hold off on making the PR if this is challenging, but I will keep you posted if I make any progress. |
|
@DerekNonGeneric
FYI,
I think this PR is free from the minor issue. |
|
Landed in 67ecd05 |
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9 participants
Demo:
Fixes: #38641