readline: move utilities to internal modules#38466
Closed
aduh95 wants to merge 1 commit intonodejs:masterfrom
Closed
readline: move utilities to internal modules#38466aduh95 wants to merge 1 commit intonodejs:masterfrom
aduh95 wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
lib / src
jasnell
approved these changes
Apr 29, 2021
aduh95
added
the
author ready
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
Apr 30, 2021
Collaborator
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
targos
approved these changes
May 2, 2021
targos
pushed a commit
that referenced
this pull request
May 2, 2021
PR-URL: #38466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
|
Landed in 54dfdbc |
targos
pushed a commit
that referenced
this pull request
May 3, 2021
PR-URL: #38466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to help the work happening on #37947.