tools: use mktemp to create the workspace directory#38432
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
tools: use mktemp to create the workspace directory#38432lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
the
tools
aduh95
approved these changes
Apr 27, 2021
| echo "Deleting temporary workspace" | ||
|
|
||
| rm -rf "$WORKSPACE" | ||
| tar zxf "$WORKSPACE"/cli/release/npm-"$NPM_VERSION".tgz |
Contributor
There was a problem hiding this comment.
I realize this comes from the previous implementation, but the use of the quotes seems… weird. I think we're supposed to put the whole argument inside one string.
Suggested change
| tar zxf "$WORKSPACE"/cli/release/npm-"$NPM_VERSION".tgz | |
| tar zxf "${WORKSPACE}/cli/release/npm-${NPM_VERSION}.tgz" |
or
Suggested change
| tar zxf "$WORKSPACE"/cli/release/npm-"$NPM_VERSION".tgz | |
| tar zxf "$WORKSPACE/cli/release/npm-$NPM_VERSION.tgz" |
Member
Author
There was a problem hiding this comment.
This is done in multiple places so I would not change it here. I think it's better to use another PR/commit to eventually make it consistent in the whole script.
On some platforms, the TMPDIR environment variable is not set.
Trott
approved these changes
Apr 29, 2021
Member
Author
|
Landed in 63c9b5b. |
lpinca
added a commit
that referenced
this pull request
May 3, 2021
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2021
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
On some platforms, the TMPDIR environment variable is not set. PR-URL: #38432 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms, the TMPDIR environment variable is not set.