fs: fix validation of negative offset to avoid abort

[jasnell]

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #24640

[Linkgoron]

I think that the real issue is only in write as negative offset is already checked in validateOffsetLengthRead, however there is no negative check in validateOffsetLengthWrite.

Note that the check for length is also broken in write, the following aborts for me as well - so maybe it makes sense to fix it in this PR as well:

fs.open('./tst/some-file.file', 'w+', (err, fd) => {
  fs.write(fd, Buffer.from('text'), 0, -10, (err) => {
    console.log(err);
  });
})

[jasnell]

I think that the real issue is only in write as negative offset is already checked

Yeah, I modified the reads here just for consistency.

so maybe it makes sense to fix it in this PR as well

Sigh. Yeah, missed that. Will add that tomorrow. done!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37748/

[RaisinTen]

Would it make sense to also move validateInteger(offset, 'offset', 0); into validateOffsetLengthRead and validateOffsetLengthWrite? That way, we could have just one validation for each field.

[jasnell]

Would it make sense to also move validateInteger(offset, 'offset', 0); into validateOffsetLengthRead and validateOffsetLengthWrite? That way, we could have just one validation for each field.

Perhaps, but let's save that for a separate PR.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37763/ 💚

[jasnell]

Landed in 4af15df