debugger: fix auto-fixable lint issues in inspect library code#38411
Merged
Trott merged 2 commits intonodejs:masterfrom Apr 28, 2021
Merged
debugger: fix auto-fixable lint issues in inspect library code#38411Trott merged 2 commits intonodejs:masterfrom
Trott merged 2 commits intonodejs:masterfrom
Conversation
github-actions
bot
added
inspector
jasnell
approved these changes
Apr 26, 2021
targos
approved these changes
Apr 26, 2021
lpinca
approved these changes
Apr 26, 2021
cjihrig
approved these changes
Apr 27, 2021
RaisinTen
approved these changes
Apr 27, 2021
Collaborator
RaisinTen
added
the
author ready
Collaborator
For issues that ESLint can fix automatically, fix them. PR-URL: nodejs#38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
For issues that ESLint can fix automatically, fix them. PR-URL: nodejs#38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
Author
|
Landed in 3d070d0...bdb6c59 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
Author
|
@targos I don't think this should be backport-blocked. I believe this will cherry-pick cleanly to v14.x-staging and I don't think it will cause any problems. Am I wrong? (With I think only one exception, these are all space/formatting changes.) |
Member
Author
Oh, wait, that label was added weeks ago. Hey, @richardlau, this one should be cherry-pickable at this point, right? I know the subsequent ones I suggested cherry-picking used |
Member
|
It didn't land cleanly when I added the label, but it's possible it does now. I just removed the label. |
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 19, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: nodejs#38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 19, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: nodejs#38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
|
This one cherry-picks cleanly onto v14.x-staging. |
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: #38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: nodejs#38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
For issues that ESLint can fix automatically, fix them. PR-URL: nodejs#38411 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.