doc: restore minimum Xcode version for macOS#38266
Merged
richardlau merged 1 commit intonodejs:masterfrom Apr 18, 2021
Merged
Conversation
nodejs-github-bot
added
build
richardlau
referenced
this pull request
Apr 16, 2021
PR-URL: #36691 Fixes: #25789 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
cjihrig
approved these changes
Apr 16, 2021
richardlau
added
the
author ready
BethGriggs
approved these changes
Apr 16, 2021
jasnell
approved these changes
Apr 17, 2021
Trott
approved these changes
Apr 17, 2021
marsonya
approved these changes
Apr 17, 2021
lpinca
approved these changes
Apr 17, 2021
nodejs#36691 accidentally reverted the change to the minimum version of Xcode for macOS. PR-URL: nodejs#38266 Refs: nodejs@4268fae#r49622017 Refs: nodejs#37872 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in 767643f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36691 accidentally reverted the
change to the minimum version of Xcode for macOS.
Refs: 4268fae#r49622017
Refs: #37872
cc @targos