typings: add JSDoc typings for readline#38253
Closed
VoltrexKeyva wants to merge 1 commit intonodejs:masterfrom
Closed
typings: add JSDoc typings for readline#38253VoltrexKeyva wants to merge 1 commit intonodejs:masterfrom
VoltrexKeyva wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Apr 16, 2021
Collaborator
targos
reviewed
Apr 16, 2021
marsonya
reviewed
Apr 19, 2021
marsonya
approved these changes
Apr 21, 2021
Trott
previously requested changes
Apr 24, 2021
Trott
reviewed
Apr 24, 2021
Trott
reviewed
Apr 27, 2021
Trott
reviewed
May 1, 2021
Trott
approved these changes
May 1, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without the startup performance comments restored.
Added JSDoc typings for the `readline` lib module.
Collaborator
jasnell
added
author ready
Member
|
Landed in 46d83b3 |
jasnell
pushed a commit
that referenced
this pull request
May 4, 2021
Added JSDoc typings for the `readline` lib module. PR-URL: #38253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
Added JSDoc typings for the `readline` lib module. PR-URL: #38253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added JSDoc typings for the
readlinelib module.