bootstrap: freeze more intrinsics#38217
Merged
aduh95 merged 1 commit intonodejs:masterfrom Apr 21, 2021
Merged
Conversation
ExE-Boss
reviewed
Apr 12, 2021
Contributor
ExE-Boss
left a comment
There was a problem hiding this comment.
These exist on primordials:
node/lib/internal/per_context/primordials.js
Lines 214 to 219 in 13c931a
ExE-Boss
reviewed
Apr 13, 2021
Contributor
ExE-Boss
left a comment
There was a problem hiding this comment.
You forgot to add these to the const { ... } = primordials block.
Contributor
Author
Thanks for the reminder, I didn't forget, I'm waiting for #38215 to land before putting work into this :) |
guybedford
approved these changes
Apr 19, 2021
Contributor
guybedford
left a comment
There was a problem hiding this comment.
Thanks for filling these in!
Collaborator
Collaborator
PR-URL: nodejs#38217 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Contributor
Author
|
Landed in 7264dbd |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
PR-URL: #38217 Reviewed-By: Guy Bedford <guybedford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several intrinsics were missing, and the comments were referencing an outdated version of ECMAScript spec.
Blockedon#37263,#38211, and#38215.