tls: fix tlsSocket.setMaxSendFragment results in an abort #38170
Merged
aduh95 merged 1 commit intonodejs:masterfrom Apr 21, 2021
Merged
tls: fix tlsSocket.setMaxSendFragment results in an abort #38170aduh95 merged 1 commit intonodejs:masterfrom
aduh95 merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Apr 9, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Can you please add tests?
Author
|
aduh95
reviewed
Apr 9, 2021
aduh95
reviewed
Apr 10, 2021
Member
|
@EladKeyshawn thanks a lot for addressing these issues! Since you open a couple PRs at the moment, would you mind reading about our commit message guidelines? They are referenced when opening a PR as well :-) |
Member
|
Please consider addressing Antoine's nits and taking Ruben's advice regarding the collaborator guidelines :] |
Author
Thanks man! |
This comment has been minimized.
This comment has been minimized.
Author
|
Can someone help me understand why the CI won't pass? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Apr 12, 2021
EladKeyshawn
changed the title
Collaborator
RaisinTen
added
the
author ready
Author
|
@benjamingr Hey is this waiting for something? |
Member
|
@ronag I think this can land :) |
jasnell
approved these changes
Apr 20, 2021
PR-URL: nodejs#38170 Fixes: nodejs#38169 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
eladkeyshawn-tls-setMaxSendFragment-abort
branch
from
6a269bd to
6e3f985
Compare
Contributor
|
Landed in 6e3f985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #38169