perf_hooks: fix loop delay resolution validation#38166
Closed
aduh95 wants to merge 3 commits intonodejs:masterfrom
Closed
perf_hooks: fix loop delay resolution validation#38166aduh95 wants to merge 3 commits intonodejs:masterfrom
aduh95 wants to merge 3 commits intonodejs:masterfrom
Conversation
addaleax
approved these changes
Apr 9, 2021
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
This seems fine, but why not just widen the type of interval on the C++ type to uint64_t?
aduh95
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Flarna
approved these changes
Apr 9, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Apr 9, 2021
jasnell
approved these changes
Apr 9, 2021
Collaborator
cjihrig
approved these changes
Apr 9, 2021
Flarna
pushed a commit
that referenced
this pull request
Apr 11, 2021
Fixes: #38160 PR-URL: #38166 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
|
Landed in 548cbf0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #38160