test: skip test-crypto-dh-keys on armv6 and armv7#38076
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: skip test-crypto-dh-keys on armv6 and armv7#38076Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
The test is too slow to run on the Raspberry Pi bots. (It takes over 500 seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip it on armv6 and armv7. Refs: nodejs#34289
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Apr 4, 2021
lpinca
approved these changes
Apr 4, 2021
marsonya
added
the
author ready
jasnell
reviewed
Apr 6, 2021
| if ((process.config.variables.arm_version === '6') || | ||
| (process.config.variables.arm_version === '7')) { | ||
| common.skip('Too slow for armv6 and armv7 bots'); | ||
| } |
Member
There was a problem hiding this comment.
I notice that there's another PR that does this. Maybe it would be worthwhile to add a common.isSlowArm type property to common/index.js to make this check more reusable?
jasnell
approved these changes
Apr 6, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
Landed in 098a4d6 |
jasnell
pushed a commit
that referenced
this pull request
Apr 7, 2021
The test is too slow to run on the Raspberry Pi bots. (It takes over 500 seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip it on armv6 and armv7. Refs: #34289 PR-URL: #38076 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The test is too slow to run on the Raspberry Pi bots. (It takes over 500 seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip it on armv6 and armv7. Refs: #34289 PR-URL: #38076 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is too slow to run on the Raspberry Pi bots. (It takes over 500
seconds to run on Pi 3 bots and over 900 seconds on Pi 2 bots.) Skip
it on armv6 and armv7.
Refs: #34289