Skip to content

deps: backport bc2e393 from v8 upstream#3792

Merged
evanlucas merged 1 commit intonodejs:masterfrom
evanlucas:backport
Nov 14, 2015
Merged

deps: backport bc2e393 from v8 upstream#3792
evanlucas merged 1 commit intonodejs:masterfrom
evanlucas:backport

Conversation

@evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Nov 12, 2015

Original commit message:

[tools] Make gen-postmortem-metadata.py more reliable

Instead of basing matches off of whitespace, walk the
inheritance chain and include any classes that inherit
from Object.

R=machenbach@chromium.org,jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1435643002

Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

R=@indutny

@jasnell jasnell added the v8 engine Issues and PRs related to the V8 dependency. label Nov 12, 2015
@trevnorris
Copy link
Contributor

trevnorris commented Nov 12, 2015

LGTM

1 similar comment
@indutny
Copy link
Member

indutny commented Nov 12, 2015

LGTM

@indutny indutny added land-on-v5.x post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. labels Nov 12, 2015
bnoordhuis
bnoordhuis reviewed Nov 13, 2015
View reviewed changes
deps/v8/tools/gen-postmortem-metadata.py
Copy link
Member

@bnoordhuis bnoordhuis Nov 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to ask: why not just .strip()?

Copy link
Contributor Author

@evanlucas evanlucas Nov 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back on it, that is what it probably should have been...

Copy link
Contributor

@thefourtheye thefourtheye Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted a patch for the same: https://codereview.chromium.org/1443963004

@bnoordhuis
Copy link
Member

bnoordhuis commented Nov 13, 2015

LGTM

@evanlucas
Copy link
Contributor Author

evanlucas commented Nov 13, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/719/

@evanlucas
Copy link
Contributor Author

evanlucas commented Nov 13, 2015

weird, looks like only arm and windows builds ran?

@evanlucas
Copy link
Contributor Author

evanlucas commented Nov 14, 2015

ok, trying CI again https://ci.nodejs.org/job/node-test-pull-request/726/

@rvagg
Copy link
Member

rvagg commented Nov 14, 2015

@joaocgreis same problem as yesterday, something's up with Jenkins, perhaps it's more complicated than just a wonky freshness detection?

@evanlucas
Copy link
Contributor Author

evanlucas commented Nov 14, 2015

I guess I'll hold off on landing until we get it sorted out?

@rvagg
Copy link
Member

rvagg commented Nov 14, 2015

Yes please @evanlucas, also @nodejs/collaborators please note that CI is not currently doing full runs, until you get a full run passing for your tests you won't have full assurance that your changes can land. The @nodejs/build team is working on resolving this but we're fighting with Jenkins on this and it's a bit like playing wac-a-mole while riding a bucking bull.

@evanlucas
Copy link
Contributor Author

evanlucas commented Nov 14, 2015

Cool. Thanks. Let me know if I can help in any way :]

@joaocgreis
Copy link
Member

joaocgreis commented Nov 14, 2015

@evanlucas CI should be good again, started a run for this PR: https://ci.nodejs.org/job/node-test-pull-request/731/

@evanlucas
deps: backport bc2e393 from v8 upstream
70405d4 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{nodejs#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: nodejs#3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@evanlucas evanlucas closed this Nov 14, 2015
@evanlucas evanlucas deleted the backport branch November 14, 2015 14:12
@evanlucas evanlucas merged commit 70405d4 into nodejs:master Nov 14, 2015
@evanlucas
Copy link
Contributor Author

evanlucas commented Nov 14, 2015

Thanks! Landed in 70405d4

evanlucas pushed a commit that referenced this pull request Nov 17, 2015
@Fishrock123
deps: backport bc2e393 from v8 upstream
fd0253b 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: #3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
ofrobots pushed a commit to ofrobots/node that referenced this pull request Dec 1, 2015
@ofrobots
deps: backport bc2e393 from v8 upstream
98e5d38 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{nodejs#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: nodejs#3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
ofrobots pushed a commit to ofrobots/node that referenced this pull request Dec 4, 2015
@ofrobots
deps: backport bc2e393 from v8 upstream
014c27a 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{nodejs#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

Ref: nodejs#3792
PR-URL: nodejs#4106
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
evanlucas pushed a commit that referenced this pull request Dec 4, 2015
@ofrobots
deps: backport bc2e393 from v8 upstream
1e324d8 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

Ref: #3792
PR-URL: #4106
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 10, 2016

I'm going to add LTS watch to this and backport it when we do the next batch

@nodejs/collaborators last chance to veto

@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

@nodejs/lts

@rvagg
Copy link
Member

rvagg commented Mar 14, 2016

looks OK to me for LTS I think, would love input from @nodejs/post-mortem wrt v4 support for this and how much it actually matters.

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 17, 2016

perhaps @mhdawson has some thoughts

@davepacheco
Copy link
Contributor

davepacheco commented Mar 22, 2016

What's the question with respect to postmortem?

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
deps: backport bc2e393 from v8 upstream
42348cc 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{nodejs#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

Ref: nodejs#3792
PR-URL: nodejs#4106
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
deps: backport bc2e393 from v8 upstream
8663738 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{nodejs#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

Ref: nodejs#3792
PR-URL: nodejs#4106
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 16, 2016

@davepacheco if this should be backported to v4

@davepacheco
Copy link
Contributor

davepacheco commented Apr 18, 2016 •
edited
Loading

I'm not aware of postmortem tools that use JSMap or JSSet. If those are the only affected classes, I don't think this would matter. But then, I don't know how anybody would have noticed in the first place, so maybe something does use these? Or maybe there's some other metadata that's affected?

(Edited to clarify I was talking about JSMap, not Map.)

@mhdawson
Copy link
Member

mhdawson commented Apr 18, 2016

@thealphanerd the IBM tools don't currently use that port mortem data so not needed from that perspective. I know that @yunong does use the mdb port mortem tools and mentioned above that he'd like this to be landed so maybe he can comment on the need to backport.

@evanlucas
Copy link
Contributor Author

evanlucas commented Apr 18, 2016

I noticed it when using llnode.

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 18, 2016

ping @indutny re: llnode

@indutny
Copy link
Member

indutny commented Apr 19, 2016

llnode doesn't really have support for this, at least not yet. +0 from me

@MylesBorins
Copy link
Contributor

MylesBorins commented May 17, 2016

@nodejs/collaborators does anyone have an interest in this being backported?

@indutny
Copy link
Member

indutny commented May 17, 2016

Not me.

@jasnell
Copy link
Member

jasnell commented May 17, 2016

hmm.. I'm +0 on it I think.

MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
deps: backport bc2e393 from v8 upstream
1480968 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: #3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 1, 2016

I've gone ahead and landed this on staging. If anyone has any objections please feel free to make them here or on the proposal issue that will be incoming tomorrow

MylesBorins pushed a commit that referenced this pull request Jun 23, 2016
deps: backport bc2e393 from v8 upstream
c3761a0 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: #3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
deps: backport bc2e393 from v8 upstream
de00f91 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: #3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 28, 2016
2016-06-28, Version 4.4.7 'Argon' (LTS)
0974fc6 
This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.

Notable Changes:

- debugger:
  - All properties of an array (aside from length) can now be printed
    in the repl (cjihrig)
    #6448
- npm:
  - Upgrade npm to 2.15.8 (Rebecca Turner)
    #7412
- stream:
  - Fix for a bug that became more prevalent with the stream changes
    that landed in v4.4.5. (Anna Henningsen)
    #7160
- V8:
  - Fix for a bug in crankshaft that was causing crashes on arm64
    (Myles Borins)
    #7442
  - Add missing classes to postmortem info such as JSMap and JSSet
    (evan.lucas)
    #3792
MylesBorins pushed a commit that referenced this pull request Jun 28, 2016
2016-06-28, Version 4.4.7 'Argon' (LTS)
21535e8 
This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.

Notable Changes:

- debugger:
  - All properties of an array (aside from length) can now be printed
    in the repl (cjihrig)
    #6448
- npm:
  - Upgrade npm to 2.15.8 (Rebecca Turner)
    #7412
- stream:
  - Fix for a bug that became more prevalent with the stream changes
    that landed in v4.4.5. (Anna Henningsen)
    #7160
- V8:
  - Fix for a bug in crankshaft that was causing crashes on arm64
    (Myles Borins)
    #7442
  - Add missing classes to postmortem info such as JSMap and JSSet
    (evan.lucas)
    #3792
gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Jun 29, 2016
@gibfahn
deps/v8z: backport bc2e393 from v8 upstream
4079730 
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: nodejs/node#3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.