test: remove references to unsupported AIX versions#37826
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove references to unsupported AIX versions#37826richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
richardlau
added
test
richardlau
force-pushed
the
housekeeping
branch
from
6cf85d8 to
e9de4e6
Compare
gireeshpunathil
approved these changes
Mar 20, 2021
Trott
approved these changes
Mar 20, 2021
sxa
approved these changes
Mar 20, 2021
Member
sxa
left a comment
sxa
left a comment
There was a problem hiding this comment.
Makes sense. I doubt there are many people trying to use it on earlier versions now that are likely to complain :-)
cjihrig
approved these changes
Mar 20, 2021
AshCripps
approved these changes
Mar 20, 2021
Collaborator
Collaborator
richardlau
added
the
author ready
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/36889/ (:heavy_check_mark:) |
The `filehandle.utimes()` and `fs.futimes()` APIs work on all versions of AIX that are supported by this version of Node.js. PR-URL: nodejs#37826 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com>
richardlau
force-pushed
the
housekeeping
branch
from
e9de4e6 to
cda60c5
Compare
Member
Author
|
Landed in cda60c5. |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
The `filehandle.utimes()` and `fs.futimes()` APIs work on all versions of AIX that are supported by this version of Node.js. PR-URL: #37826 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filehandle.utimes()andfs.futimes()APIs work on all versionsof AIX that are supported by this version of Node.js.
cc @nodejs/platform-aix