Skip to content

crypto: fix DiffieHellman argument validation#37810

Merged
aduh95 merged 1 commit intonodejs:masterfrom
aduh95:crypto-dh-true
Mar 23, 2021
Merged

crypto: fix DiffieHellman argument validation#37810
aduh95 merged 1 commit intonodejs:masterfrom
aduh95:crypto-dh-true

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 19, 2021

Fixes: #37808

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 19, 2021
mscdex
mscdex reviewed Mar 19, 2021
View reviewed changes
lib/internal/crypto/diffiehellman.js Outdated
else
else if (generator !== true)
generator = toBuf(generator, genEncoding);
else
Copy link
Contributor

@mscdex mscdex Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to add multiple lines below, can we please add braces to the if/else ifs/else to make things more readable?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 20, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36862/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 20, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36874/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2021
@aduh95
crypto: fix DiffieHellman argument validation
98ff5ac 
Fixes: nodejs#37808

PR-URL: nodejs#37810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 23, 2021

Landed in 98ff5ac

@aduh95 aduh95 merged commit 98ff5ac into nodejs:master Mar 23, 2021
@aduh95 aduh95 deleted the crypto-dh-true branch March 23, 2021 10:04
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@aduh95 @ruyadorno
crypto: fix DiffieHellman argument validation
7925938 
Fixes: #37808

PR-URL: #37810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
crypto: fix DiffieHellman argument validation
46ece20 
Fixes: #37808

PR-URL: #37810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@mscdex mscdex mscdex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"crypto.createDiffieHellman" results in an abort

7 participants

@aduh95 @nodejs-github-bot @mscdex @panva @jasnell @benjamingr @RaisinTen