tty: validate file descriptor to avoid int32 overflow#37809
Merged
aduh95 merged 1 commit intonodejs:masterfrom Mar 23, 2021
Merged
tty: validate file descriptor to avoid int32 overflow#37809aduh95 merged 1 commit intonodejs:masterfrom
aduh95 merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Mar 19, 2021
aduh95
added
the
author ready
Collaborator
BridgeAR
approved these changes
Mar 19, 2021
lpinca
approved these changes
Mar 19, 2021
Collaborator
Collaborator
RaisinTen
approved these changes
Mar 20, 2021
Collaborator
Fixes: nodejs#37805 PR-URL: nodejs#37809 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95
force-pushed
the
tty-isatty-int32
branch
from
544bd16 to
134fb5a
Compare
Contributor
Author
|
Landed in 134fb5a |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37805