Closed
Conversation
ryzokuken
approved these changes
Mar 16, 2021
marsonya
approved these changes
Mar 16, 2021
richardlau
reviewed
Mar 16, 2021
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
What's the rationale for mentioning the team (that if you are not in the nodejs org in GitHub you won't be able to see) in the API docs?
If the intention is to call out that upstream for GYP is now gyp-next, perhaps instead of a tacked on sentence the original paragraph could be reworded to something like:
node-gyp is a build system based on the gyp-next fork of Google's GYP tool...
Member
Author
|
@richardlau PTAL |
richardlau
approved these changes
Mar 16, 2021
mmarchini
approved these changes
Mar 16, 2021
cjihrig
approved these changes
Mar 17, 2021
Trott
approved these changes
Mar 18, 2021
Member
Author
|
Landed in a2fdef0 |
gengjiawen
added a commit
that referenced
this pull request
Mar 18, 2021
PR-URL: #37765 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 20, 2021
PR-URL: #37765 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37765 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nodejs/gyp