THP ELF assembly: Add .note.GNU-stack section#37688
Closed
jayaddison wants to merge 2 commits intonodejs:masterfrom
jayaddison:build/large-pages-assembly-gnu-stack
Closed
THP ELF assembly: Add .note.GNU-stack section#37688jayaddison wants to merge 2 commits intonodejs:masterfrom jayaddison:build/large-pages-assembly-gnu-stack
jayaddison wants to merge 2 commits intonodejs:masterfrom
jayaddison:build/large-pages-assembly-gnu-stack
Conversation
This indicates to GNU binutils that it can unset the executable stack flag on the binary that it is building. Refs: #17933
Collaborator
Contributor
Author
|
It looks like Theory, based on the error message: For reference since the build logs may disappear, the error message is: |
Collaborator
danbev
approved these changes
Mar 10, 2021
Collaborator
Contributor
Author
Collaborator
Contributor
|
Landed in 90008f8. |
Merged
targos
pushed a commit
that referenced
this pull request
Apr 27, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 30, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: nodejs/node#17933 Related: nodejs/node#37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This indicates to GNU binutils that it can unset the executable stack flag on the binary that it is building.
Refs: #17933
cc @gabrielschulhof @bnoordhuis (from the
gitshortlog in this part of the codebase)cc @danbev (as discussed, for review)
Two developer notes to aid review:
%progbitswith a percentage symbol. The approach here uses@progbitsinstead, which is the form documented in thebinutilsdocumentation here.nodeis a cross-platform binary and I believe this section could be relevant for other platforms.Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.