test: improve error reporting in test-child-process-pipe-dataflow#37632
Merged
Trott merged 1 commit intonodejs:masterfrom Mar 9, 2021
Merged
test: improve error reporting in test-child-process-pipe-dataflow#37632Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
Trott
added
the
flaky-test
nodejs-github-bot
added
needs-ci
Collaborator
Collaborator
Member
Author
|
@nodejs/testing This could use some reviews. |
gireeshpunathil
approved these changes
Mar 8, 2021
cjihrig
approved these changes
Mar 9, 2021
When the test fails, it usually ends up failing on the assertion that
`wc` did not find as many bytes as it expected. That may not be
helpful if it is caused by a failure earlier in the command
pipeline ( cat | grep | wc ). Move the byte check to
`process.on('exit')` so that other error handlers that report the
existence of errors run first.
Refs: nodejs#25988
PR-URL: nodejs#37632
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 7f54dd4 |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
When the test fails, it usually ends up failing on the assertion that
`wc` did not find as many bytes as it expected. That may not be
helpful if it is caused by a failure earlier in the command
pipeline ( cat | grep | wc ). Move the byte check to
`process.on('exit')` so that other error handlers that report the
existence of errors run first.
Refs: #25988
PR-URL: #37632
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
When the test fails, it usually ends up failing on the assertion that
`wc` did not find as many bytes as it expected. That may not be
helpful if it is caused by a failure earlier in the command
pipeline ( cat | grep | wc ). Move the byte check to
`process.on('exit')` so that other error handlers that report the
existence of errors run first.
Refs: #25988
PR-URL: #37632
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the test fails, it usually ends up failing on the assertion that
wcdid not find as many bytes as it expected. That may not behelpful if it is caused by a failure earlier in the command
pipeline ( cat | grep | wc ). Move the byte check to
process.on('exit')so that other error handlers that report theexistence of errors run first.
Refs: #25988