Closed
Conversation
Contributor
Author
|
did my best with the commit message naming, if |
bnb
force-pushed
the
bnb/changelog-typo-fix
branch
from
4a47a68 to
121051a
Compare
Contributor
Author
|
removed the change in the auto-generated bit and to just update the Notable Changes bit, per advice from @MylesBorins. |
RaisinTen
approved these changes
Mar 4, 2021
Member
Contributor
Author
|
Will update that today 👍🏻 |
marsonya
approved these changes
Mar 4, 2021
lpinca
approved these changes
Mar 4, 2021
Trott
approved these changes
Mar 4, 2021
bnb
force-pushed
the
bnb/changelog-typo-fix
branch
from
121051a to
e6786e5
Compare
bnb
changed the title
Contributor
Author
|
Force pushed over the previous commit to use the |
RaisinTen
added
the
author ready
jasnell
approved these changes
Mar 5, 2021
Contributor
Author
|
The failed macOS build is unrelated to the contents of this PR 😬 |
jasnell
pushed a commit
that referenced
this pull request
Mar 5, 2021
PR-URL: #37590 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in ed633f2 |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37590 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed a small typo in the changelog for the release today while writing a tweet for it, wanted to help fix it. Since this typo is directly committed and is in the commit message, I'm not sure if this can/should land but figured I'd throw it up on the possibility that folks think it should land.